Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New solution to height/width #60

Open
martincognite opened this issue May 30, 2018 · 0 comments
Open

New solution to height/width #60

martincognite opened this issue May 30, 2018 · 0 comments
Labels
backlog efficiency enhancement New feature or request

Comments

@martincognite
Copy link
Contributor

Using react-sizeMe decreases performance a bit. We might want to give responsibility to the user on this one -- or look into another way of doing it cheaper.
@martincognite martincognite added the enhancement New feature or request label May 30, 2018
evancharlton added a commit that referenced this issue Jul 30, 2018
@evancharlton
Have LineChart be the size of its container (#117)
bd7aa68 
Leverage `react-sizeme` to make LineChart always be the size of its
container, instead of needing to specify dimensions.

Related to #60
evancharlton added a commit that referenced this issue Jul 30, 2018
@evancharlton
Have LineChart be the size of its container (#117)
f3aee1b 
Leverage `react-sizeme` to make LineChart always be the size of its
container, instead of needing to specify dimensions.

Related to #60
@evancharlton evancharlton mentioned this issue Jul 30, 2018
Merged
evancharlton added a commit that referenced this issue Jul 30, 2018
@evancharlton
Have LineChart be the size of its container (#117) (#119)
b13599f 
Leverage `react-sizeme` to make LineChart always be the size of its
container, instead of needing to specify dimensions.

Related to #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog efficiency enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rj126 @martincognite