revert the action of copy; instead throw an error.

Author: yuxies

src/MibSModel.cpp

@@ -1120,11 +1120,10 @@ MibSModel::loadProblemData(const CoinPackedMatrix& matrix,
    CoinPackedMatrix *newMatrix = NULL;
    CoinPackedMatrix *matrix1 = NULL; // YX: w/ appended equality constrs
 
-   // YX: need col mat to start; cp to matrix1 if row-ordered
+   // YX: note that MibS defaults to using a column matrix.
    if(!matType){
-      matrix1 = new CoinPackedMatrix();
-      matrix1->copyOf(matrix);
-      matrix1->reverseOrdering();
+      throw CoinError("Expect a column-oriented matrix. Try matrix.reverseOrdering() before loading the matrix.", 
+         "loadProblemData", "MibSModel");
    }
 
    // --- prepare for equality constraints (if any) ---
@@ -1184,17 +1183,12 @@ MibSModel::loadProblemData(const CoinPackedMatrix& matrix,
 
    // YX: add rows to the problem matrix and link pointers to vectors 
    if(numRows > inputNumRows){
-      if(!matrix1){
-         matrix1 = new CoinPackedMatrix();
-         matrix1->copyOf(matrix);
-      }
+      matrix1 = new CoinPackedMatrix();
+      matrix1->copyOf(matrix);
       matrix1->reverseOrdering();
 
       rowMatrix = matrix;
-      // YX: switch if matrix was col ordered
-      if(matType){
-         rowMatrix.reverseOrdering();
-      }
+      rowMatrix.reverseOrdering();
       const double * matElements = rowMatrix.getElements();
       const int * matIndices = rowMatrix.getIndices();
       const int * matStarts = rowMatrix.getVectorStarts();