Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs cbc binaries for many different systems, instead of using the correct cbc binary provided by the coin-or-cbc dependency #740

Open
3 of 13 tasks
yurivict opened this issue Mar 13, 2024 · 3 comments

Comments

@yurivict
Copy link

Details for the issue

What did you do?

Ran tests.

What did you expect to see?

Success.

What did you see instead?

Many failures, see the log.

Useful extra information

The project installs architecture-specific binaries, like:

%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/32/__init__.py
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/32/__pycache__/__init__%%PYTHON_EXT_SUFFIX%%.opt-1.pyc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/32/__pycache__/__init__%%PYTHON_EXT_SUFFIX%%.pyc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/32/cbc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/32/coin-license.txt
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/64/__init__.py
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/64/__pycache__/__init__%%PYTHON_EXT_SUFFIX%%.opt-1.pyc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/64/__pycache__/__init__%%PYTHON_EXT_SUFFIX%%.pyc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/64/cbc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/64/coin-license.txt
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/arm64/__init__.py
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/arm64/__pycache__/__init__%%PYTHON_EXT_SUFFIX%%.opt-1.pyc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/arm64/__pycache__/__init__%%PYTHON_EXT_SUFFIX%%.pyc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/arm64/cbc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/linux/arm64/coin-license.txt
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/osx/64/__init__.py
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/osx/64/__pycache__/__init__%%PYTHON_EXT_SUFFIX%%.opt-1.pyc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/osx/64/__pycache__/__init__%%PYTHON_EXT_SUFFIX%%.pyc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/osx/64/cbc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/osx/64/coin-license.txt
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/win/32/__init__.py
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/win/32/__pycache__/__init__%%PYTHON_EXT_SUFFIX%%.opt-1.pyc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/win/32/__pycache__/__init__%%PYTHON_EXT_SUFFIX%%.pyc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/win/32/cbc.exe
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/win/32/coin-license.txt
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/win/64/__init__.py
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/win/64/__pycache__/__init__%%PYTHON_EXT_SUFFIX%%.opt-1.pyc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/win/64/__pycache__/__init__%%PYTHON_EXT_SUFFIX%%.pyc
%%PYTHON_SITELIBDIR%%/pulp/solverdir/cbc/win/64/cbc.exe

This is instead of using the cbc executable provided by the coin-or-cbc-2.10.11 dependency.
It is wrong to install all binaries on all systems.
Why does it run the linux executable pulp/solverdir/cbc/linux/64/cbc on FreeBSD?
Shouldn't it do this at least based on the system name?

What operating system are you using?

  • Windows: ( version: ___ )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • FreeBSD 14.0

I'm using python version:

  • 3.9
  • 3.8
  • 3.9
  • 3.10
  • 3.11
  • Other: ___

I installed PuLP via:

@pchtsp
Copy link
Collaborator

pchtsp commented Mar 13, 2024 via email

@yurivict
Copy link
Author

yurivict commented Apr 6, 2024

I am just a port/package maintainer, and I don't have resources for PRs, unfortunately.

@yurivict
Copy link
Author

yurivict commented Apr 6, 2024

This would require a deep re-work.
The PULP package should depend on relevant external binary dependencies, and shouldn't install other OS executables.
The current structure of installed files appears to be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants