feat: app redirects replace location #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for commercelayer-dashboard-apps ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
if conceptually you are happy with the changes of this PR, I can commit to reset package lock to upstream. Don't know if you have conventions to always update lock but if not would say don't need for this kind of change. |
|
Hi Max, good catch! Thanks for your PR, we'll discuss about these changes in the next days and we'll ping you back soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #154
What I did
Replace app redirects to replace the location.
SKU and SKU Lists apps. Maybe there's more but those are the ones I found.
This prevents infinite redirects if trying to navigate back in history.
How to test
Start the server and click SKUs App, navigation should work with appropriate redirect, try to navigate back in history, you should be back to home. Can repeat for SKU Lists App.
Checklist