Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scope of commercetools-test-lib in dependencies #1428

Closed
katmatt opened this issue Jun 13, 2017 · 0 comments
Closed

Fix scope of commercetools-test-lib in dependencies #1428

katmatt opened this issue Jun 13, 2017 · 0 comments
Assignees
@katmatt
Milestone
v1.20.0

Comments

@katmatt
Copy link
Contributor

katmatt commented Jun 13, 2017

Our module commercetools-test-lib isn't deployed to maven central, but is required with scope compilefrom our commercetools-java-client-ahc-1_8 module (https://github.com/commercetools/commercetools-jvm-sdk/blob/master/commercetools-java-client-ahc-1_8/pom.xml#L48). This prevents us from fixing commercetools/commercetools-jvm-sdk-scala-add-ons#6.

Since the changed line was changed last at 15. Feb 2016, this shows that no one used the commercetools-java-client-ahc-1_8 module after that date.
@katmatt katmatt added this to the v1.20.0 milestone Jun 13, 2017
@katmatt katmatt self-assigned this Jun 13, 2017
@katmatt katmatt mentioned this issue Jun 13, 2017
Merged
@katmatt katmatt added the review label Jun 13, 2017
@katmatt katmatt removed the review label Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katmatt katmatt

Labels
None yet
Projects
None yet
Milestone
v1.20.0
Development

No branches or pull requests
1 participant
@katmatt