Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default i18n getOrKey or getOrEmpty? #687

Open
lauraluiz opened this issue Nov 2, 2017 · 0 comments
Open

Default i18n getOrKey or getOrEmpty? #687

lauraluiz opened this issue Nov 2, 2017 · 0 comments
Labels
Milestone

Comments

@lauraluiz
Copy link
Contributor

In some places (e.g. HandlebarsI18nHelper) the default is getOrEmpty, so it returns empty when the message key is not found. But on other places it has been decided to use getOrKey to allow to write unlocalized messages or simply to display something even if it's a message key (sometimes that can be more useful than nothing).

@lauraluiz lauraluiz added this to the v1.0.0-RC1 milestone Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant