-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not show Category description twice #393
Comments
@nkuehn actually it was never defined what was going into those two boxes (banner and jumbotron), so I filled it at some point with the category description to have something to show, but that's only App related. @trangng is there any particular purpose to the upper banner? I can think of two possible usages:
|
@nkuehn I've fixed the HTML issue from the bonus point in my development branch, so far as a basic rendered. Thanks for reporting it! |
@trangng I need some feedback about what to do with the upper banner:
|
@lauraluiz I'd also go for option 1, but the problem is images I can not change in MC and the category images are always different for every categories. So actually the purpose for it was to leave it to the customer to choose btw. image or text banner. So if someone uses the image banner it definitely needs to be in the CMS then |
My two cents: Don't even bother about features that have no native support in CTP (i.e. work only with custom fields or abusing other things or implicit frontend-internal conventions) . -> Just remove category image suport completely until it's a built-in feature? |
Let's just put the image as CMS (it's as easy as to hardcode it in the HTML and can be adapted for showcases, plus it's nicer) and the content of the root category. If we ever have images in categories, then we can easily change it. |
Adding a longer category description completely breaks the category page layout.
Steps to reproduce: Add a long description text. Reload.
Steps to fix:
Bonus Points: properly handle HTML formatted content in the category view. HTML editor is the default in the platform, so people will write HTML by default. Either "clean" it or render it or both.
Source: Andreas Gottschalk doing a demo setup.
The text was updated successfully, but these errors were encountered: