Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show Category description twice #393

Open
nkuehn opened this issue Mar 8, 2016 · 7 comments
Open

Do not show Category description twice #393

nkuehn opened this issue Mar 8, 2016 · 7 comments
Assignees
Labels
Milestone

Comments

@nkuehn
Copy link

nkuehn commented Mar 8, 2016

Adding a longer category description completely breaks the category page layout.

Steps to reproduce: Add a long description text. Reload.

Steps to fix:

  • do not show the category description in the category header banner
  • maybe do not show the category name twice at all, reserving the box above the products for the description

Bonus Points: properly handle HTML formatted content in the category view. HTML editor is the default in the platform, so people will write HTML by default. Either "clean" it or render it or both.

Source: Andreas Gottschalk doing a demo setup.

@nkuehn nkuehn added the bug label Mar 8, 2016
@lauraluiz lauraluiz added this to the 0.57.0 milestone Mar 8, 2016
@lauraluiz
Copy link
Contributor

@nkuehn actually it was never defined what was going into those two boxes (banner and jumbotron), so I filled it at some point with the category description to have something to show, but that's only App related.

@trangng is there any particular purpose to the upper banner? I can think of two possible usages:

  • Put description of the parent (root) category, e.g. Women, Men, Accessoires. And leave the jumbotron below for the current subcategory, if any.
  • Leave it as free CMS content, category unrelated (I would need some text for that).

@lauraluiz
Copy link
Contributor

@nkuehn I've fixed the HTML issue from the bonus point in my development branch, so far as a basic rendered. Thanks for reporting it!

@lauraluiz
Copy link
Contributor

@nkuehn I moved the description too long bug to another issue: #398

@lauraluiz lauraluiz modified the milestones: 0.57.0, 0.58.0 Mar 12, 2016
@lauraluiz
Copy link
Contributor

@trangng I need some feedback about what to do with the upper banner:

  • upper banner for root category and lower banner for the current category (if it's a root category then it's not shown), or
  • upper banner for free category unrelated text from CMS and lower banner as it is

@trangng
Copy link
Contributor

trangng commented Apr 4, 2016

@lauraluiz I'd also go for option 1, but the problem is images I can not change in MC and the category images are always different for every categories.
Let's have the upper banner for root categories and for the rest the lower one as you suggested.

So actually the purpose for it was to leave it to the customer to choose btw. image or text banner.

So if someone uses the image banner it definitely needs to be in the CMS then

@nkuehn
Copy link
Author

nkuehn commented Apr 4, 2016

My two cents: Don't even bother about features that have no native support in CTP (i.e. work only with custom fields or abusing other things or implicit frontend-internal conventions) .

-> Just remove category image suport completely until it's a built-in feature?

@lauraluiz
Copy link
Contributor

Let's just put the image as CMS (it's as easy as to hardcode it in the HTML and can be adapted for showcases, plus it's nicer) and the content of the root category. If we ever have images in categories, then we can easily change it.

@lauraluiz lauraluiz assigned lauraluiz and unassigned trangng Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants