Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hacktoberfest] Improve benchmark UI, show the results of the last N releases. #771

Open
ahmetoz opened this issue Sep 24, 2021 · 0 comments
Labels
Hacktoberfest Hacktoberfest 2021

Comments

@ahmetoz
Copy link
Contributor

ahmetoz commented Sep 24, 2021

Situation:

Benchmark test results are written as JSON to benchmarks.json which is saved in the gh-pages branch of the repo. The JSON used as a source for the chart UI.

Results as a chart can be found: https://commercetools.github.io/commercetools-sync-java/benchmarks/
Screenshot 2021-09-24 at 10 20 27

Complication:

The current benchmark chart has more than 20 items and increasing on every release,
Also in the graph, we are pointing to the hash of the commit, but it’s not easy to reason and compare it based on the releases.

Resolution:
Show the results of the last N releases (N might be sth easy to reason from the chart, let's say 5) and backup the history to another file. For the label, try showing the release number instead of commit hash.

CONTRIBUTING, CODE_OF_CONDUCT

@ahmetoz ahmetoz added the Hacktoberfest Hacktoberfest 2021 label Sep 24, 2021
@ahmetoz ahmetoz changed the title [Hactoberfest] Improve benchmark UI, show the results of the last N releases. [Hacktoberfest] Improve benchmark UI, show the results of the last N releases. Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Hacktoberfest 2021
Projects
None yet
Development

No branches or pull requests

1 participant