Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS version of the starter kit #2297

Closed
pavvell opened this issue Jul 15, 2021 · 1 comment · Fixed by #2615
Closed

TS version of the starter kit #2297

pavvell opened this issue Jul 15, 2021 · 1 comment · Fixed by #2615
Assignees
Labels
💅 Type: Enhancement Improves existing code 🛠 Type: Tooling Things related to development tools for the repository

Comments

@pavvell
Copy link

pavvell commented Jul 15, 2021

Current custom application starter kit is available only in JS, would be good to have a TS version of it, as all core libraries as I understand already have declaration files (as was mentioned in #1668)

current starter kit: https://github.com/commercetools/merchant-center-application-kit/tree/main/application-templates

@pavvell pavvell added 💡 Type: Idea Propose a new idea 🚀 Type: New Feature Something new labels Jul 15, 2021
@emmenko
Copy link
Member

emmenko commented Jul 20, 2021

Hi @pavvell ,

Thanks for reaching out and for the interest in using TS.

Technically it's already possible to use TS. However, some uikit components are not fully migrated to TS yet, thus missing the type declarations. In this case, you would need to provide the type declarations on your own (you can see an example here https://github.com/commercetools/merchant-center-application-kit/tree/main/%40types).

We will have a starter kit available in TS once all core packages have type declarations, as otherwise it's confusing.

If you want though, you can already start developing the Custom Application using TS, as all the tools have TS support (mc-scripts, babel, eslint, etc.).

If you use Jest, take a look here: https://github.com/commercetools/merchant-center-application-kit/tree/main/packages/jest-preset-mc-app#typescript-support

Hope this helps you with the next steps. Don't hesitate to reach out if you need further help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💅 Type: Enhancement Improves existing code 🛠 Type: Tooling Things related to development tools for the repository
Projects
None yet
3 participants