Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use image dimensions graphql field #66

Open
zeina-idris opened this issue Nov 5, 2018 · 0 comments
Open

Use image dimensions graphql field #66

zeina-idris opened this issue Nov 5, 2018 · 0 comments
Labels
blocked Depends on another issue to be fixed first graphql Related with GraphQL

Comments

@zeina-idris
Copy link
Contributor

Fix how we implement images url according to image dimensions field in graphql fields, instead of getting random sized images.

Sunrise data now gets the images url with random sizes (e.g
..../products/072750_1_large/.jpg or
..../products/072750_1_medium/.jpg ) with no specification. Despite the fact that in the source images we have all sizes to each image that are not being used, so we should be able to get the images according to those sizes.
@zeina-idris zeina-idris added the graphql Related with GraphQL label Nov 5, 2018
@skyriakou skyriakou added the blocked Depends on another issue to be fixed first label Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Depends on another issue to be fixed first graphql Related with GraphQL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeina-idris @skyriakou