Skip to content

Commit 944d734

Browse files
authored
Add --no-sandbox to silence Google Chrome warnings MacOS
1 parent 93dd06f commit 944d734

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

.github/workflows/main.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ jobs:
278278
echo "Running test_xeus_cpp in Firefox"
279279
python ${{ env.BUILD_PREFIX }}/bin/emrun.py --browser="firefox" --kill_exit --timeout 60 --browser-args="--headless" test_xeus_cpp.html
280280
echo "Running test_xeus_cpp in Google Chrome"
281-
python ${{ env.BUILD_PREFIX }}/bin/emrun.py --browser="Google Chrome" --kill_exit --timeout 60 --browser-args="--headless" test_xeus_cpp.html
281+
python ${{ env.BUILD_PREFIX }}/bin/emrun.py --browser="Google Chrome" --kill_exit --timeout 60 --browser-args="--headless --no-sandbox" test_xeus_cpp.html
282282
else
283283
# Install Google Chrome
284284
wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ It is possible to run the Emscripten tests in a headless browser. We will run ou
121121
echo "Running test_xeus_cpp in Firefox"
122122
python $BUILD_PREFIX/bin/emrun.py --browser="firefox" --kill_exit --browser-args="--headless" test_xeus_cpp.html
123123
echo "Running test_xeus_cpp in Google Chrome"
124-
python $BUILD_PREFIX/bin/emrun.py --browser="Google Chrome" --kill_exit --browser-args="--headless" test_xeus_cpp.html
124+
python $BUILD_PREFIX/bin/emrun.py --browser="Google Chrome" --kill_exit --browser-args="--headless --no-sandbox" test_xeus_cpp.html
125125
```
126126

127127
To do this on Ubuntu x86 execute the following

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ It is possible to run the Emscripten tests in a headless browser. We will run ou
122122
echo "Running test_xeus_cpp in Firefox"
123123
python $BUILD_PREFIX/bin/emrun.py --browser="firefox" --kill_exit --timeout 60 --browser-args="--headless" test_xeus_cpp.html
124124
echo "Running test_xeus_cpp in Google Chrome"
125-
python python $BUILD_PREFIX/bin/emrun.py --browser="Google Chrome" --kill_exit --timeout 60 --browser-args="--headless" test_xeus_cpp.html
125+
python python $BUILD_PREFIX/bin/emrun.py --browser="Google Chrome" --kill_exit --timeout 60 --browser-args="--headless --no-sandbox" test_xeus_cpp.html
126126
```
127127

128128
To do this on Ubuntu x86 execute the following

docs/source/InstallationAndUsage.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ It is possible to run the Emscripten tests in a headless browser. We will run ou
110110
echo "Running test_xeus_cpp in Firefox"
111111
python $BUILD_PREFIX/bin/emrun.py --browser="firefox" --kill_exit --timeout 60 --browser-args="--headless" test_xeus_cpp.html
112112
echo "Running test_xeus_cpp in Google Chrome"
113-
python $BUILD_PREFIX/bin/emrun.py --browser="Google Chrome" --kill_exit --timeout 60 --browser-args="--headless" test_xeus_cpp.html
113+
python $BUILD_PREFIX/bin/emrun.py --browser="Google Chrome" --kill_exit --timeout 60 --browser-args="--headless --no-sandbox" test_xeus_cpp.html
114114
115115
To do this on Ubuntu x86 execute the following
116116

0 commit comments

Comments
 (0)