Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robust saving #682

Merged
merged 87 commits into from
Nov 25, 2020
Merged

Robust saving #682

merged 87 commits into from
Nov 25, 2020

Conversation

wwqrd
Copy link
Contributor

@wwqrd wwqrd commented Nov 22, 2020 •
edited
Loading

Refactor of the saving mechanisms, in order to streamline the process, whilst simultaneously adding back up feature.

  • Protocols module, has been removed
  • "unbundle" and "load" (and "bundle" and "save") are combined since in usage these do not need to be used independently
  • Meta data about the loaded file has been combined with the session module
  • A backup is created when a file is saved.

Outstanding tasks

  • Restore locking higher order action creators
  • Add user friendly error dialogs
  • Ensure system menu is working correctly
  • Delete old back up when creating a new one? create backup for the first save
  • Ensure preview is working correctly
  • Add copy to friendly error dialogs

wwqrd added 30 commits November 12, 2020 16:02
@wwqrd
Combine other and utils
975a675
@wwqrd
Work in progress new import export methods
d20caa3
@wwqrd
Start properly speccing file util functions
b3b1a70
@wwqrd
Example export function in session
02029ba
@wwqrd
importNetcanvas
945da9f
@wwqrd
Stub exportNetcanvas tests
167a868
@wwqrd
Readable error on save failed
8386d2f
@wwqrd
exportNetcanvas fail tests
9d7d86a
@wwqrd
Resolve test for exportNetcanvas
5d0d73a
@wwqrd
WIP backupAndSubstitute()
1fa3125
@wwqrd
Rename functions and test deploy function
9ddcea3
@wwqrd
Fix file import function name
27d85a7
@wwqrd
WIP read errors
32c8f4a
@wwqrd
readProtocol tests
9e38f16
@wwqrd
Valid test for reading a protocol
7d186ab
@wwqrd
Finish file tests for validation
6872c11
@wwqrd
Rename file -> netcanvasFile
9393f51 
Also update some function names
@wwqrd
Stub out open netcanvas action
84f3f5e
@wwqrd
Stub saveAs
c8ebb6a
@wwqrd
Compact session change tests
54a2bf9
@wwqrd
Open protocol session reducer
a6c246a
@wwqrd
Save success reducer handler in session
a25eecc
@wwqrd
Test save action in session
e10d083
@wwqrd
Test for saveAs action
3dbe267
@wwqrd
Remove redundent active protocol Id
c0ba11d
@wwqrd
Update protocol state to update on SESSION/OPEN_NETCANVAS_SUCCESS
c254064
@wwqrd
Open protocol when filename is known from launchpad
12d58a0
@wwqrd
Reset state when Protocol is unmounted
964e9ff
@wwqrd
Open protocol from dialog
c11d515
@wwqrd
Create new network canvas file
a493db4
wwqrd added 14 commits November 23, 2020 11:20
@wwqrd wwqrd marked this pull request as ready for review November 24, 2020 16:51
@jthrilly jthrilly self-requested a review November 25, 2020 12:06
@wwqrd wwqrd merged commit d257303 into master Nov 25, 2020
@jthrilly jthrilly linked an issue Nov 25, 2020 that may be closed by this pull request
Safer Saving #680
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthrilly jthrilly jthrilly approved these changes

Assignees

@wwqrd wwqrd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Safer Saving
2 participants
@wwqrd @jthrilly