Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview assets #731

Merged
merged 18 commits into from
Sep 23, 2021
Merged

Preview assets #731

merged 18 commits into from
Sep 23, 2021

Conversation

wwqrd
Copy link
Contributor

@wwqrd wwqrd commented Aug 6, 2021

Add preview functionality to asset browser, this is particularly useful for network data.

Assets can also be downloaded for viewing outside of the app.

Resolves #687

controls

preview

@rebeccamadsen
Copy link
Contributor

I super love this feature, let me just say. I ran into no major issues, and only a couple of small things.

On loading json preview in development protocol, I got a warning:

Warning: Each child in a list should have a unique "key" prop.

I kind of think this is an artifact of the oddness of the json for the development protocol, because it on purpose doesn't have the "name" variable correct, so some show up as null?

Also really minor, but the development quadrant images don't show up on a white background. I'm not really recommending anything, because they download just fine, but I suppose an above and beyond solution could be to offer to toggle the background color for images, however I'm not convinced this is necessary.

@wwqrd
Copy link
Contributor Author

wwqrd commented Sep 9, 2021

Thanks @rebeccamadsen I've resolved those warnings.

When looking at this afresh I thought it also make sense to add the preview/download functionality to the Codebook.

Copy link
Contributor

@rebeccamadsen rebeccamadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding it to codebook was a great addition. Looks good to me!

@wwqrd wwqrd merged commit 9c066c9 into master Sep 23, 2021
@wwqrd wwqrd deleted the feature/preview-assets branch September 23, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to preview and/or export items from the resource library
2 participants