Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to V4 protocol version fail #689

Closed
lleleux opened this issue Dec 24, 2020 · 4 comments · Fixed by #691
Closed

Migration to V4 protocol version fail #689

lleleux opened this issue Dec 24, 2020 · 4 comments · Fixed by #691
Assignees
Labels

Comments

@lleleux
Copy link

lleleux commented Dec 24, 2020

Hi,

When I try to migrate from v3 to v4, I have this error :
Screenshot from 2020-12-24 00-50-16
I'm on Ubuntu 20.10, and my /home is on another partition than /tmp.

I asked to write the new version to /tmp, and it worked. But I have the same problem when I copy the protocol to my /home, update it, and try to save it.

As a workaround, I work on another partition for the moment.

Thank you for your work.

Laurent

@lleleux
Copy link
Author

lleleux commented Dec 24, 2020

If I'm not wrong, you are using the "rename" function to move the file from /tmp to the new location. But I think it doesn't work cross partitions. You need maybe to copy and then unlink the file.

If this can help you ;-)

@jthrilly
Copy link
Member

jthrilly commented Jan 4, 2021

Thanks @lleleux! You're almost certainly right about the root cause. We had a bit of an internal discussion about "renaming" vs "moving" (where moving is first copying and then unlinking). It seems there is in fact a difference between the two.

Thank you for catching this. A fix will be coming as soon as we are all back in the office.

@wwqrd
Copy link
Contributor

wwqrd commented Jan 11, 2021

This might also explain some of the issues with the snap packages (which are sand-boxed with their own virtual /tmp/ dir), since protocols are created in the temp dir before being renamed to user space.

@wwqrd
Copy link
Contributor

wwqrd commented Jan 20, 2021

Should be resolved by #691 which changes the rename method to copy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants