-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fix handling of bad magics #148
base: master
Are you sure you want to change the base?
Conversation
Before I can get to the actual fix, I'm having some problems with the test framework :)
full version:$ pytest -v tests/test_magics.py =============================== test session starts ================================ platform linux -- Python 3.7.6, pytest-5.4.1, py-1.8.1, pluggy-0.12.0 -- /home/sefkw/mc3/envs/celltestsui/bin/python cachedir: .pytest_cache metadata: {'Python': '3.7.6', 'Platform': 'Linux-5.4.0-7634-generic-x86_64-with-debian-bullseye-sid', 'Packages': {'pytest': '5.4.1', 'py': '1.8.1', 'pluggy': '0.12.0'}, 'Plugins': {'xdist': '1.32.0', 'html': '2.1.1', 'metadata': '1.8.0', 'cov': '2.8.1', 'forked': '1.1.2', 'nbval': '0.9.5'}} rootdir: /home/sefkw/code/external/nbval plugins: xdist-1.32.0, html-2.1.1, metadata-1.8.0, cov-2.8.1, forked-1.1.2, nbval-0.9.5 collected 2 items |
Hmm, re. problem 2 above: travis does not have the problem. So I guess it's related to my environment; I'll try a new environment and see what happens. |
I had been using conda. I tried in a newly created python virtualenv (using my system python 3) - same problem :( I suppose I should compare the packages here to the ones on travis:
|
It's not the dependencies. Locally I get
|
I could try to narrow down, but I don't suppose you want to take a guess @vidartf ? |
Ok, the test results are now as I expect, i.e. they reflect the bug I'll fix in this PR:
|
Fixes #147