-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better checks for ffmpeg nvenc version #288
Comments
We'll need to integrate newer ffnvcodecs conda-forge/ffnvcodec-headers-feedstock#26 |
Thanks Mark! 🙏 Also wonder if we can now drop this as we are building with newer CUDA 12.x's ffmpeg-feedstock/recipe/conda_build_config.yaml Lines 29 to 32 in 1705b1d
Edit: Think we can also use this opportunity to add CUDA 12.8 ( conda-forge/conda-forge-pinning-feedstock#6980 ) |
no you can't since the encoding API doesn't match. thats why i had to build the matrix. i hit this problem myself. |
For more info see these defines https://github.com/FFmpeg/FFmpeg/blob/43be8d07281caca2e88bfd8ee2333633e1fb1a13/libavcodec/nvenc.h#L96 which fix features depending on the compile time status. I think unless we package the equivalent of |
i was truthfully surprised that the CUDA version checks were not runtime checks. I wonder how software even ships cuda powered FFMPEG? maybe just supporting a subset of features.... |
Comment:
Apparently the versions are listed here:
FFmpeg/FFmpeg@n7.0.2...n7.1#diff-ba8b555333cbe9c4d768147d8a7abb152281257770aa314cc057a31f43460fecR247
so we could improve our version checking
The text was updated successfully, but these errors were encountered: