Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better checks for ffmpeg nvenc version #288

Open
hmaarrfk opened this issue Oct 2, 2024 · 5 comments
Open

Better checks for ffmpeg nvenc version #288

hmaarrfk opened this issue Oct 2, 2024 · 5 comments
Labels

Comments

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Oct 2, 2024

Comment:

Apparently the versions are listed here:

FFmpeg/FFmpeg@n7.0.2...n7.1#diff-ba8b555333cbe9c4d768147d8a7abb152281257770aa314cc057a31f43460fecR247

so we could improve our version checking

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Feb 7, 2025

We'll need to integrate newer ffnvcodecs conda-forge/ffnvcodec-headers-feedstock#26

@jakirkham
Copy link
Member

jakirkham commented Feb 7, 2025

Thanks Mark! 🙏

Also wonder if we can now drop this as we are building with newer CUDA 12.x's

cuda_version_for_ffnvcodec:
- None
- 12.2 # [linux64 or win]
- 12.4 # [linux64 or win or aarch64]

Edit: Think we can also use this opportunity to add CUDA 12.8 ( conda-forge/conda-forge-pinning-feedstock#6980 )

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Feb 8, 2025

no you can't since the encoding API doesn't match. thats why i had to build the matrix. i hit this problem myself.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Feb 8, 2025

For more info see these defines https://github.com/FFmpeg/FFmpeg/blob/43be8d07281caca2e88bfd8ee2333633e1fb1a13/libavcodec/nvenc.h#L96 which fix features depending on the compile time status. I think unless we package the equivalent of libnvidia-encode and libnvidia-decode we need to build out the matrix.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Feb 9, 2025

i was truthfully surprised that the CUDA version checks were not runtime checks.

I wonder how software even ships cuda powered FFMPEG? maybe just supporting a subset of features....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants