New trampoline #609
Closed
New trampoline #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Apr 18, 2024
| .join(".prefix") | ||
| }); | ||
| // First create the target prefix if it doesn't exist yet. | ||
| fs::create_dir_all(&target_prefix).expect("could not create target prefix"); |
There was a problem hiding this comment.
I think this should result in a user error instead of an expect.
The canonicalize could be an expect because we already created the directory.
| .parent() | ||
| .expect("since we joined with target_dir there must be a parent"), | ||
| )?; | ||
| ) -> Result<[PathsEntry; 1], std::io::Error> { |
There was a problem hiding this comment.
This doesnt have to be an array anymore.
| launcher.extend_from_slice(&LAUNCHER_MAGIC_NUMBER); | ||
|
|
||
| let target_location = target_dir.join(&relative_path_script_exe); | ||
| fs::create_dir_all(target_location.parent().unwrap())?; |
|
Did you build the binaries yourself? I am a little hesitant to include binaries without a proper reference to the source. I have no way to verify that this binary isnt mallicious. |
|
Nope, I copied them from UVs git repo :) but could be cool to build ourselves and make the magic number "pixi" instead of "uvuv", haha |
|
Shall we close this in favor of #639 ? |
|
yeah, let's close this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug I encountered with white spaces in the path to the prefix on Windows, and gives us win-arm64 support. I briefly tried to build the trampoline for win-32 as well, but didn't work out because I am missing
dlltool.exe.This does not create 2 files anymore, but just a single .exe file. For some reason, the script is stored as a zip encoded file (not sure if I would have done it that way, but whatever). IMO it could be just the text file with offsets stored somewhere.
If we decide to use it we should add some more attribution :)