Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Docker-based integration tests with embedded integration tests #31

Closed
C0urante opened this issue Sep 17, 2020 · 0 comments
Closed
Assignees

Comments

@C0urante
Copy link

(Migrated from wepay#285)

When we wrote the Docker-based integration tests, there were no options for running an embedded instance of the Connect framework in a unit test. Now, there's the EmbeddedConnectCluster class provided and supported by Kafka that we can leverage for integration tests, and Confluent also provides an option for bringing up an embedded instance of Schema Registry.

Using both of these, it should be possible to recreate the existing tests very closely but with an improved workflow for running and expanding them that doesn't require shell scripts or Docker image building, and also enables more flexibility in the test cases covered. We can build on this to add specific tests for upsert/delete, for example.

@C0urante C0urante self-assigned this Sep 17, 2020
C0urante added a commit that referenced this issue Oct 5, 2020
#37)

* GH-31: Port Dockerized integration tests to embedded integration tests

* GH-31: Try to get integration tests working on Jenkins

* GH-31: Address review feedback

* GH-31: Clear buckets before deleting them in integration tests
@C0urante C0urante closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant