Skip to content

Commit 898aec4

Browse files
committed
Add a note about returning error for node-published volumes
1 parent f72fbbe commit 898aec4

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

spec.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2523,13 +2523,15 @@ If plugin has `STAGE_UNSTAGE_VOLUME` node capability then:
25232523

25242524
Otherwise `NodeExpandVolume` MUST be called after successful `NodePublishVolume`.
25252525

2526+
A plugin that has `STAGE_UNSTAGE_VOLUME` node capability and supports `NodeExpandVolume` ONLY after `NodeStageVolume` and before `NodePublishVolume` but not after `NodePublishVolume` may return `FAILED_PRECONDITION` error code if `NodeExpandVolume` is called after `NodePublishVolume` - CO MUST NOT retry.
2527+
25262528
If a plugin only supports expansion via the `VolumeExpansion.OFFLINE` capability, then the volume MUST first be taken offline and expanded via `ControllerExpandVolume` (see `ControllerExpandVolume` for more details), and then node-staged or node-published before it can be expanded on the node via `NodeExpandVolume`.
25272529

25282530
The `staging_target_path` field is not required, for backwards compatibility, but the CO SHOULD supply it.
25292531
Plugins can use this field to determine if `volume_path` is where the volume is published or staged,
25302532
and setting this field to non-empty allows plugins to function with less stored state on the node.
25312533

2532-
If a plugin does not support expansion of `readonly` volumes it can return `Volume in use or readonly` error and CO must not retry.
2534+
If a plugin does not support expansion of `readonly` volumes it may return `FAILED_PRECONDITION` error code and CO MUST NOT retry.
25332535

25342536
```protobuf
25352537
message NodeExpandVolumeRequest {

0 commit comments

Comments
 (0)