Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dttools: use a hash table to map data to array index in priority queue #4055

Open
JinZhou5042 opened this issue Feb 5, 2025 · 2 comments
Open

Comments

@JinZhou5042
Copy link
Member

In the current implementation of priority queue, the way to get the array index of a data is to traverse the whole array until a match is found, this could be significantly sped up if there is a hash_table in the struct priority to map the data directly to its corresponding index.

@dthain
Copy link
Member

dthain commented Feb 5, 2025

No more modifying the priority queue for a while :)

As I said from the beginning:

  • First, determine all the actions the scheduler needs to perform on the set of ready tasks.
  • Then, design a data structure that satisfies those actions efficiently.

@JinZhou5042
Copy link
Member Author

I agree with you. Just a note, if #4056 wants to have a priority-based temp file replication, for example, files with less replicas are prioritized to replicate, then this might be needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants