Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vine: manager shutdown=True parameter raises AttributeError #4062

Open
EamonTracey opened this issue Feb 14, 2025 · 0 comments
Open

vine: manager shutdown=True parameter raises AttributeError #4062

EamonTracey opened this issue Feb 14, 2025 · 0 comments
Assignees
Labels
good-first-issue A simpler issue that would be a good starting point for a new contributor TaskVine

Comments

@EamonTracey
Copy link
Contributor

The ndcctools.taskvine.Manager class has a shutdown parameter. If set to true, the manager should shutdown all workers when the manager finishes. However, an AttributeError is raised.

import ndcctools.taskvine as vine
manager = vine.Manager(shutdown=True)
Exception ignored in: <function Manager.__del__ at 0x7f731bd7c220>
Traceback (most recent call last):
  File "./python3.12/site-packages/ndcctools/taskvine/manager.py", line 160, in __del__
  File "./python3.12/site-packages/ndcctools/taskvine/manager.py", line 152, in _free
AttributeError: 'Manager' object has no attribute 'shutdown_workers'

The issue seems to be that the nonexistent method shutdown_workers is called. Instead, workers_shutdown is the correct method.

@EamonTracey EamonTracey added good-first-issue A simpler issue that would be a good starting point for a new contributor TaskVine labels Feb 14, 2025
@EamonTracey EamonTracey self-assigned this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue A simpler issue that would be a good starting point for a new contributor TaskVine
Projects
None yet
Development

No branches or pull requests

1 participant