Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vine: Compose remote function calls #4044

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

btovar
Copy link
Member

@btovar btovar commented Jan 28, 2025

For #4043.

Merge Checklist

The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update: Update the manual to reflect user-visible changes.
  • Type Labels: Select a github label for the type: bugfix, enhancement, etc.
  • Product Labels: Select a github label for the product: TaskVine, Makeflow, etc.
  • PR RTM: Mark your PR as ready to merge.

@btovar btovar requested review from dthain and tphung3 January 28, 2025 18:32
Copy link
Member

@dthain dthain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection, but I also haven't deeply understood the problem yet. Perhaps ask @tphung3 who has been thinking about functions and context?

@tphung3
Copy link
Contributor

tphung3 commented Jan 28, 2025

I just tested the new test code and the serverless_composed test runs with the current master (without the proposed changes). I believe this is because cloudpickle inspects each function's possible call stack and also pickles the functions that the original function depends on. So composed functions should not be a problem. @btovar Can you confirm this on your end? If true then perhaps the problem in #4011 is something else?

@btovar
Copy link
Member Author

btovar commented Jan 28, 2025

Thanks @tphung3! I'm trying to figure out what not worked before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants