Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require PR submitters to provide a reason for skipping notes #7

Open
jlebon opened this issue Nov 1, 2022 · 1 comment
Open

Require PR submitters to provide a reason for skipping notes #7

jlebon opened this issue Nov 1, 2022 · 1 comment

Comments

@jlebon
Copy link
Member

jlebon commented Nov 1, 2022

Using a skip-notes label is convenient, but humans are creatures of habit and it doesn't take long before reviewers get used to seeing the skip-notes label and scan right past it.

One way to counter this is instead of a label, PR submitters that want to skip release notes have to either provide e.g. a footer in the initial PR description (such as skip-notes: <reason>) or alternatively as a stand-alone comment. This will increase the likelihood that reviewers read the reason and they may then decide to discuss it.

@bgilbert
Copy link
Contributor

bgilbert commented Nov 1, 2022

We'd need to special-case Dependabot, since it can't add configurable text to PRs. (Or, really, we'd have a configurable list of exempt users.) But that would also be helpful in flagging Dependabot PRs where additional commits have been added without a corresponding release note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants