Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Test Gaia with CometMock #2866

Closed
2 tasks
p-offtermatt opened this issue Dec 20, 2023 · 2 comments
Closed
2 tasks

EPIC: Test Gaia with CometMock #2866

p-offtermatt opened this issue Dec 20, 2023 · 2 comments
Assignees
Labels
admin: epic An EPIC -- meta issue used to track a body of work admin: key-result A key result (in the context of OKRs) S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.

Comments

@p-offtermatt
Copy link
Contributor

p-offtermatt commented Dec 20, 2023

Problem

We want to use CometMock with the Gaia e2e tests to run them faster and lay the foundations to run more tests.

Closing criteria

In the Gaia e2e tests, it is possible to spin up a local testnet that uses CometMock instead of CometBFT.

Prerequisite: The Gaia e2e framework should undergo a general refactor and cleanup,
which itself doesn't integrate CometMock, but which should already keep in mind this will be done later.
This issue tracks the general Gaia e2e refactor:
#2406

Task list

The rough tasks to do are:

Tasks

These can be made separate issues, but for now I think they are both relatively minor and interconnected, so I will leave them as tasks.

@p-offtermatt p-offtermatt added scope: testing Code review, testing, making sure the code is following the specification. admin: epic An EPIC -- meta issue used to track a body of work S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth labels Dec 20, 2023
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Dec 20, 2023
@p-offtermatt p-offtermatt moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Dec 20, 2023
@mpoke mpoke added the admin: key-result A key result (in the context of OKRs) label Dec 20, 2023
@mpoke
Copy link
Contributor

mpoke commented Mar 21, 2024

@p-offtermatt Could you please add a reason why we don't want to do this and close the issue?

@p-offtermatt
Copy link
Contributor Author

It turns out that instead of using CometMock, for the use cases we considered it is more reasonable to use an in-memory testing framework like ibctesting, which completely gets rid of the need for a consensus engine.

For testing the internal logic, this approach is much faster, and easier to maintain. If we are worried about the CLI itself, we should test that separately, and not mix that too much with testing the internal logic.

For this reason, it was decided we would close this issue for now and shift the focus away from integrating CometMock.

@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Mar 21, 2024
@p-offtermatt p-offtermatt moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin: epic An EPIC -- meta issue used to track a body of work admin: key-result A key result (in the context of OKRs) S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants