fix: remove packet data remarshaling (#8065)

* fix: remove packet data remarshaling

* chore: update upload artifact

* chore: update download artifact

* redact 8.6.0

Author: gjermundgaraba

.github/workflows/test.yml

@@ -61,19 +61,19 @@ jobs:
       - name: Split pkgs into 4 files
         run: split -d -n l/4 pkgs.txt pkgs.txt.part.
       # cache multiple
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: '${{ github.sha }}-00'
           path: ./pkgs.txt.part.00
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: '${{ github.sha }}-01'
           path: ./pkgs.txt.part.01
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: '${{ github.sha }}-02'
           path: ./pkgs.txt.part.02
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: '${{ github.sha }}-03'
           path: ./pkgs.txt.part.03
@@ -96,15 +96,15 @@ jobs:
             **/**.go
             go.mod
             go.sum
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: '${{ github.sha }}-${{ matrix.part }}'
         if: env.GIT_DIFF
       - name: test & coverage report creation
         run: |
           cat pkgs.txt.part.${{ matrix.part }} | xargs go test -mod=readonly -timeout 30m -coverprofile=${{ matrix.part }}profile.out -covermode=atomic -tags='ledger test_ledger_mock'
         if: env.GIT_DIFF
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: '${{ github.sha }}-${{ matrix.part }}-coverage'
           path: ./${{ matrix.part }}profile.out
@@ -120,19 +120,19 @@ jobs:
             **/**.go
             go.mod
             go.sum
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: '${{ github.sha }}-00-coverage'
         if: env.GIT_DIFF
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: '${{ github.sha }}-01-coverage'
         if: env.GIT_DIFF
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: '${{ github.sha }}-02-coverage'
         if: env.GIT_DIFF
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: '${{ github.sha }}-03-coverage'
         if: env.GIT_DIFF

CHANGELOG.md

@@ -34,7 +34,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 # Changelog
 
-## [v8.6.0](https://github.com/cosmos/ibc-go/releases/tag/v8.6.0) - 2025-02-27
+## [v8.6.1](https://github.com/cosmos/ibc-go/releases/tag/v8.6.1) - 2025-02-27
 
 - [ASA-2025-004](https://github.com/cosmos/ibc-go/security/advisories/GHSA-jg6f-48ff-5xrw) Fix ASA-2025-004
 

go.mod

@@ -4,7 +4,7 @@ module github.com/cosmos/ibc-go/v8
 
 retract (
 	// contain ASA-2025-004 vulnerability
-	[v8.0.0, v8.5.3]
+	[v8.0.0, v8.6.0]
 )
 
 require (

modules/apps/transfer/ibc_module.go

@@ -189,13 +189,6 @@ func (im IBCModule) OnRecvPacket(
 		ackErr = errorsmod.Wrapf(ibcerrors.ErrInvalidType, "cannot unmarshal ICS-20 transfer packet data")
 		logger.Error(fmt.Sprintf("%s sequence %d", ackErr.Error(), packet.Sequence))
 		ack = channeltypes.NewErrorAcknowledgement(ackErr)
-	} else {
-		bz := data.GetBytes()
-		if !bytes.Equal(bz, packet.GetData()) {
-			ackErr = errorsmod.Wrapf(ibcerrors.ErrInvalidType, "packet data did not marshal to expected bytes: %X ≠ %X", bz, packet.GetData())
-			ack = channeltypes.NewErrorAcknowledgement(ackErr)
-			im.keeper.Logger(ctx).Error(fmt.Sprintf("%s sequence %d", ackErr.Error(), packet.Sequence))
-		}
 	}
 
 	// only attempt the application logic if the packet data