CI additions, GoReleaser config and fixes to issues reported by golint and gocritic
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- md2man.go:51:4: exitAfterDefer: os.Exit will exit, and `defer func(){...}(...)` will not run
- md2man/roff.go:56:24: exported func NewRoffRenderer returns unexported type *md2man.roffRenderer, which can be annoying to use
- Run golint, gofmt, go vet, go ineffassign - Run `go test` with -v (make test does not) - Run on every push and pull request to all branches (not only master)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to test.yml:
go testwith -v (make test does not)GoReleaser config:
Produce binaries for Linux, Darwin (what people refer to as MacOS and shouldn't), FreeBSD and NetBSD,
as well as Deb and RPM packages.
The hook is triggered when a new tag is pushed.
You can see an example of the output here
That release was created automatically following the push of a new tag.
Fixes to issues reported by
golintandgocritic:defer func(){...}(...)will not run