Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH action not working for windows because of wget #1191

Open
Its-Just-Nans opened this issue Dec 30, 2024 · 5 comments · May be fixed by #1192
Open

GH action not working for windows because of wget #1191

Its-Just-Nans opened this issue Dec 30, 2024 · 5 comments · May be fixed by #1192
Labels
bug Not as expected

Comments

@Its-Just-Nans
Copy link
Contributor

Its-Just-Nans commented Dec 30, 2024

This actions assumes that wget is already installed which is not true for windows-latest

This produces the error

D:\a\_actions\crate-ci\typos\v1.28.4/action/entrypoint.sh: line 43: wget: command not found

The action requires

    - name: Install wget for Windows
      if: matrix.os == 'windows-latest'
      run: choco install wget --no-progress

Little bit related to #1095

@Its-Just-Nans Its-Just-Nans linked a pull request Dec 30, 2024 that will close this issue
@epage
Copy link
Collaborator

epage commented Dec 30, 2024

In #769, we've been also having issues with wget being needed.

#772 proposed making features optional that were unsupported by busybox. #1125 proposed providing a fallback to another common tool.

Our options for this

The question for me is what approach we should take and why. At the outset, I'm not too thrilled about entrypoint.sh installing unrelated tools.

@epage epage added the bug Not as expected label Dec 30, 2024
@Its-Just-Nans
Copy link
Contributor Author

Its-Just-Nans commented Dec 30, 2024

Thanks for the informations

I'm making a PR to at least have more documentation

Also, why not using an "input action" like download_if_needed and combine

to use curl or wget or use choco (to install it - on windows)

@Its-Just-Nans
Copy link
Contributor Author

Also, why not using cargo install typos@VERSION in entrypoint.sh

Cargo is installed on all runner no ?

@epage
Copy link
Collaborator

epage commented Dec 30, 2024

to use curl or wget or use choco (to install it - on windows)

That is a point of discussion in #772

Also, why not using cargo install typos@VERSION in entrypoint.sh

The intention behind pre-built binaries is to avoid the build-time costs.

@Its-Just-Nans
Copy link
Contributor Author

Its-Just-Nans commented Dec 30, 2024

Okay, so I propose

Add an "input action" like download_if_needed
I think most people want the typos actions work out of the box, so by default it's download_if_needed: true

Add an "input action" like wget_args
by default wget_args: "--progress=dot:mega" -> busybox user can just disable the wget poblem (fix #772)

if this download_if_needed is true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants