Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add embed SAPI sanity check #567

Closed
crazywhalecc opened this issue Dec 5, 2024 · 0 comments · Fixed by #573
Closed

Add embed SAPI sanity check #567

crazywhalecc opened this issue Dec 5, 2024 · 0 comments · Fixed by #573
Assignees
@crazywhalecc
Labels
enhancement New feature or request kind/php-and-sapi Issues related to php source and SAPI

Comments

@crazywhalecc
Copy link
Owner

Background: Sometimes changes may not affect cli and micro SAPI, but may affect embed, such as #560 #563 #564.

Adding embed tests can detect potential problems before release, cc @dunglas
@crazywhalecc crazywhalecc added enhancement New feature or request kind/php-and-sapi Issues related to php source and SAPI labels Dec 5, 2024
@crazywhalecc crazywhalecc self-assigned this Dec 5, 2024
@crazywhalecc crazywhalecc mentioned this issue Dec 10, 2024
Merged
3 tasks
@dunglas dunglas mentioned this issue Dec 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crazywhalecc crazywhalecc

Labels
enhancement New feature or request kind/php-and-sapi Issues related to php source and SAPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add embed sanity check and spc-config command crazywhalecc/static-php-cli
1 participant
@crazywhalecc