-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config for the the size of in-memory queue used for log/console data #93
Comments
- handle flush bytes limit via environment variable `SCOPE_LOG_FLUSH_LIMIT` and config parameter - keep old value as default 32768 closes criblio#93
Possible duplicate for #189 |
- handle flush bytes limit via environment variable `SCOPE_LOG_BUFFER_THRESHOLD` and config parameter - keep old value as default 32768 closes criblio#93
- handle flush bytes limit via environment variable `SCOPE_LOG_BUFFER_THRESHOLD` and config parameter - keep old value as default 32768 closes criblio#93
Closing this and replacing with issue #690. The salient concern is overall memory size and not just console data. |
My review comments: Naming/Configuration structureThe current state of this issue defines these two env vars:
What I'd propose is renaming the env vars to:
Comments in scope.ymlWe'll need to be clear that these affect two different things: TestingAs part of testing these changes, we'll want to be sure to test "reconfiguration" of a process at least manually for these two new configuration variables. I think things look like they should work, but I wonder if we might be missing a call to |
Should be user configurable
The text was updated successfully, but these errors were encountered: