Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The test runners on GitHub don't work #2118

Closed
Skully17 opened this issue Dec 24, 2024 · 3 comments
Closed

The test runners on GitHub don't work #2118

Skully17 opened this issue Dec 24, 2024 · 3 comments

Comments

@Skully17
Copy link
Contributor

The test runners currently don't pass and this is stopping PRs from being merged.

@wencagh
Copy link

wencagh commented Dec 26, 2024

These days I tried to prepare (in parallel) similar fixes as @Skully17. All CI checks are green except unit tests - almost all mqtt tests failed. I am not sure if I am missing some necessary dependency (like running process with mqtt) on my self-hosted GH runner.
I am able to support the project with a dedicated VM for self-hosted GH runner to solve the issue and as mentioned in #2092

@Skully17
Copy link
Contributor Author

Skully17 commented Jan 3, 2025

I haven't been able to make any progress with the unit tests either.
Many of the tests have already been disabled. would it be acceptable to disable these tests as well so the blocker for all other PRs can be removed?

@oberstet
Copy link
Contributor

oberstet commented Jan 3, 2025

would it be acceptable to disable these tests

if it's only a handful, defined set, like "all mqtt ones", and if that unblocks getting CI and merging going again, then +1, I'm on board, definitely. yeah, it would be absolutely crucial on a project level to get CI/PRs going again, prio 1, beyond anything. thanks for helping!

@Skully17 Skully17 closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants