Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test runners #2119

Merged
merged 20 commits into from
Jan 9, 2025
Merged

Fix test runners #2119

merged 20 commits into from
Jan 9, 2025

Conversation

Skully17
Copy link
Contributor

Ticket: #2118

The changes here fix most of the failing tests; I have been unable so far to fix the unit tests and am making this PR mainly to make it known the changes are being made and for any help that can be given

David Ellis added 19 commits December 9, 2024 17:10
Fixing test runners
a21c5f8
Fixing test runners
370461e
Fixing test runners
475f4c9
Fixing test runners
6ce2ef7
update eth-abi
511ae3f
update eth-abi
778d6cd
update eth-abi
0b60128
update eth-abi
e523a41
update eth-account
457b42e
intersphinx_mapping format has changed
d157f48
Removed sphinxcontrib.images from list of extensions because sphinxco…
f71a508 
…ntrib-images v0.9.4 doesn't work with sphinx v8.1.3
Using "isinstance" to compare types instead of "type(x) == y"
cb392c5
Using "isinstance" to compare types instead of "type(x) == y"
4569d45
Changing formatting to satisfy yapf
84d8279
Resolving mypy errors and updating python version to 3.11
9c7f01d
Added timeouts for requests so to avoid them hanging indefinitely and…
798775d 
… to satisfy bandit
- unskipping test as matterhorn is no longer being used
14ace3f 
- skipping failing mqtt tests after migrate abck to using GitHub machines for CI testing
- re-skipping test as it still fails on GitHub machine
10f5d18 
- Satisfied yapf
Removed testing on python 3.9
a63cf36
@Skully17 Skully17 marked this pull request as ready for review January 9, 2025 12:39
@Skully17
Copy link
Contributor Author

Skully17 commented Jan 9, 2025

All CI tests pass for me. hope the changes are acceptable

@oberstet
Copy link
Contributor

oberstet commented Jan 9, 2025

awesome! fantastic job making CI green again=)

I have no idea what

grafik

is exactly, but it seems unrelated/unimportant, and I really want to merge and land this work now! cool, thanks again!

@oberstet oberstet merged commit f722a22 into crossbario:master Jan 9, 2025
6 checks passed
@Skully17
Copy link
Contributor Author

Skully17 commented Jan 9, 2025

Thank you 😁

I think it's leftover from before the changes. I removed those tests with python 3.9 so they are only done with python 3.11. maybe they're still queued from before?

Great to see progress and look forward to see other PRs being merged, maybe even a new pypy version 😉

@oberstet
Copy link
Contributor

oberstet commented Jan 9, 2025

look forward to see other PRs being merged, maybe even a new pypy version

oh yeah, absolutely, would be great! fwiw, I really hope to be in a position to get involved again more myself, which I plan to do .. there is still some things to do with WAMP .. and Autobahn/Crossbar.io.

@Skully17 Skully17 deleted the fix_test_runners branch January 9, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skully17 @oberstet