Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add address book selector to the Cart shipping calculator #79

Open
matt-h opened this issue Apr 30, 2020 · 3 comments
Open

Add address book selector to the Cart shipping calculator #79

matt-h opened this issue Apr 30, 2020 · 3 comments

Comments

@matt-h
Copy link
Member

matt-h commented Apr 30, 2020

The cart shipping calculator has you put country/state/zip. If we could also have it choose from your address book this would save manual entry if the address is already in your address book.

You should still be able to set these manually if it is not in your address book.

Suggested here:

@eriktdesign
Copy link

Hey there @matt-h -- I'm working on a PR for this for Hacktoberfest. I've got a proof-of-concept working and will do a little cleanup to get it tight.

Question for you -- I'm going to need to load some javascript on the cart page. Right now I've appended my new javascript to the end of the main scripts.js file and extended the enqueue conditional to include is_cart(). I figure that makes sense rather than splitting the functionality into a new JS file, but I thought I'd see what your thoughts were. As it stands currently it's only about 20 lines of JS unminified.

@matt-h
Copy link
Member Author

matt-h commented Sep 27, 2021

@eriktdesign thanks. I think that makes sense to keep it in just one JS file. The script will be loaded on the next page (checkout) anyway so loading it on the cart I think is just fine and it will be cached once you get to the checkout.

@SamuelAshbrook
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants