feat(application): Add support for Kustomize Patches #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Borrelli <[email protected]>
|
I'm a little unsure of the goverter conversions, there are a few fields missing that I have commented out. |
|
@stevendborrelli which fields are you uncertain about? https://github.com/argoproj/argo-cd/blob/d408909df6f950dd4b1a0b898c3b77259aef394f/pkg/apis/application/v1alpha1/types.go#L521 |
Signed-off-by: Steven Borrelli <[email protected]>
stevendborrelli
changed the title
|
@blakepettersson There are new fields I was pulling from main that aren't in the last release. I've removed them in commit: 966a5ae. |
|
@janwillies @MisterMX could we get a review of this? |
|
Thanks for the PR @stevendborrelli! Changes look good to me, figuring out why the linter fails |
MisterMX
requested changes
Nov 27, 2024
Comment on lines
+3
to
+5
| go 1.21.0 | ||
|
|
||
| toolchain go1.23.2 |
There was a problem hiding this comment.
Lets leave the go version as it is as long no upgrades are necessary.
MisterMX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #208
I have:
RunIt looks like linting is broken in the Makefile.make reviewable testto ensure this PR is ready for review.How has this code been tested
We've tested this successfully internally, also confirmed by comment #208 (comment).