fix(application): Increase reconciliation timeout to 5 Minutes #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This pull request modifies the timeout for the application controller in the Crossplane project by hardcoding it to 5 minutes. The previous implementation #218 suggested using a configurable reconciliationTimeout flag, which implied it would be applied to all controllers. However, this change specifically targets only the application controller.
The decision to hardcode the timeout to 5 minutes is based on the observation that it is more straightforward to increase the timeout for applications directly, rather than introducing a configuration option. This adjustment aims to enhance the reliability and efficiency of application management by ensuring the process completes within a reasonable timeframe.
Fixes #217
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
I tested the feature with an application using the Helmfile plugin, where Helmfile rendering typically takes more than 1 minute. With the default reconciliation timeout set to 60 seconds, longer rendering processes would fail. By setting the reconciliation timeout to more than 60 seconds, I was able to successfully create an application with manifest generation taking over a minute, without encountering any errors.
Helmfile example: