Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the RDS provider documentation to specify that the username field is mandatory for defining the username of the master DB user. #1498

Closed
thiagoscodelerae opened this issue Sep 23, 2024 · 3 comments
Labels

Comments

@thiagoscodelerae
Copy link

The username field is not specified as required for DB instance creation on RDS provider documentation.
The documentation should be updated to specify this field as required.

Also, using the default value "postgres" would be good to implement if we don't set any value. (This is what AWS does on the Console as the default username option).

Affected Resource(s)
rds.aws.upbound.io/v1beta2 - Instance
https://marketplace.upbound.io/providers/upbound/provider-aws-rds/v1.12.0/resources/rds.aws.upbound.io/Instance/v1beta2

Source of this request: #1476

@thiagoscodelerae thiagoscodelerae added enhancement New feature or request needs:triage labels Sep 23, 2024
@mergenci
Copy link
Collaborator

mergenci commented Sep 25, 2024

Terraform documentation of the field states “Required unless a snapshot_identifier or replicate_source_db is provided”. Attributes of complex resources cannot be classified into a binary “required” or not. As suggested, Upjet should better include such caveats in the documentation.

Copy link

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@mergenci
Copy link
Collaborator

Closing in favor of crossplane/upjet#457.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants