Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The update of existing Azure AD app doesn't work #179

Open
1 task done
eriksML opened this issue Dec 18, 2024 · 5 comments
Open
1 task done

[Bug]: The update of existing Azure AD app doesn't work #179

eriksML opened this issue Dec 18, 2024 · 5 comments
Labels
bug Something isn't working needs:triage

Comments

@eriksML
Copy link

eriksML commented Dec 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Affected Resource(s)

applications.azuread.upbound.io/v1beta1 - Application

Resource MRs required to reproduce the bug

apiVersion: applications.azuread.upbound.io/v1beta1
kind: Application
metadata:
  name: my-app-test
  annotations:
    crossplane.io/external-name: "/applications/00000000-0000-0000-0000-000000000000"
spec:
  managementPolicies: ["Observe"]
  forProvider:
    displayName: my-app-test
    identifierUris:
    - "dummyurl.com"
  providerConfigRef:
    name: azuread-provider-config

Steps to Reproduce

  • updating the existing Azure AD application

What happened?

Hi crossplane team,

we need to update the existing azure AD application by adding redirect uris for SSO configuration.
However looks it's not working with the azuread provider the version 1.6.0.

Relevant Error Output Snippet

Warning CannotObserveExternalResource 33s managed/applications.azuread.upbound.io/v1beta1, kind=application external resource does not exist

Crossplane Version

1.18.0

Provider Version

1.6.0

Kubernetes Version

v1.31.0

Kubernetes Distribution

minikube

Additional Info

I've tried to use identifierUris as an additional field but still not working. Changing the management policy and using "*" creates a new app instead of updating the existing one. My provider config has ReadWrite permissions for all apps.

@eriksML eriksML added bug Something isn't working needs:triage labels Dec 18, 2024
@mergenci
Copy link
Collaborator

Thanks for your report @eriksML. To clarify, you're interested in importing a resource as documented here, right?

@eriksML
Copy link
Author

eriksML commented Jan 2, 2025

Hi @mergenci, yes you're right.

@turkenf
Copy link
Collaborator

turkenf commented Jan 13, 2025

Hi @eriksML,

I could not reproduce the issue on my side. Please make sure you have given the correct value to the crossplane.io/external-name annotation. It should be: crossplane.io/external-name: /applications/<Object ID>

@eriksML
Copy link
Author

eriksML commented Jan 17, 2025

Hi @turkenf,

thank you for your response. Could you send your application manifest please?
Are you using
managementPolicies: ["Observe"]
for importing the resource firstly?
My manifest is in the description where I have the correct value in the name annotation.
I've tested it again with the latest provider version and still getting the error

Warning CannotObserveExternalResource 99s (x3 over 6m56s) managed/applications.azuread.upbound.io/v1beta1, kind=application external resource does not exist

@turkenf
Copy link
Collaborator

turkenf commented Jan 17, 2025

Hi @eriksML,

thank you for your response. Could you send your application manifest please?
Are you using
managementPolicies: ["Observe"]

Yes, and the YAML file:

apiVersion: applications.azuread.upbound.io/v1beta1
kind: Application
metadata:
  annotations:
    crossplane.io/external-name: /applications/dab15385-60c1-45ca-837e-66050aaa5555
  name: test-import
spec:
  managementPolicies: ["Observe"]
  forProvider:
    displayName: example-test-import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs:triage
Projects
None yet
Development

No branches or pull requests

3 participants