Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark test.EquateErrors as deprecated #529

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Mark test.EquateErrors as deprecated #529

wants to merge 3 commits into from

Commits on Aug 20, 2023

  1. Mark test.EquateErrors as deprecated 

    See crossplane/crossplane#4514 for context.

We can't remove this (it would be a breaking API change) but I want to
discourage and redirect folks.

Signed-off-by: Nic Cope <[email protected]>
    @negz
    negz committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    db81395 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Remove error constant strings 

    To avoid doing a whole bunch of string comparison in unit tests, we also
switch to using cmpopts.EquateErrors.

Signed-off-by: Nic Cope <[email protected]>
    @negz
    negz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    9d21154 View commit details
    Browse the repository at this point in the history

  2. Move policy tests into their own file 

    This way code in policies.go has its tests in policies_test.go, not
reconciler_test.go.

Signed-off-by: Nic Cope <[email protected]>
    @negz
    negz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    8c1d597 View commit details
    Browse the repository at this point in the history