Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: pkg/resource: output progress logs in applicators #532

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

WIP: pkg/resource: output progress logs in applicators #532

wants to merge 5 commits into from

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Sep 4, 2023

Add progress logs to the applicators:

  • print creations
  • print updates/patches with diff
  • be silent on noop.

Based on #491

Signed-off-by: Dr. Stefan Schimanski [email protected]

@sttts sttts requested review from a team as code owners September 4, 2023 08:27
@sttts sttts requested review from muvaf and pedjak September 4, 2023 08:27
@sttts sttts changed the title pkg/resource: output progress logs in applicators WIP: pkg/resource: output progress logs in applicators Sep 4, 2023
@sttts sttts mentioned this pull request Sep 7, 2023
Open
3 tasks
@phisco
Copy link
Contributor

phisco commented Nov 16, 2023

@sttts, this PR is marked as ready for review, but has WIP in the title, should we move it to draft or consider it actually ready for review?

@sttts sttts marked this pull request as draft November 16, 2023 10:08
@sttts
Copy link
Contributor Author

sttts commented Nov 16, 2023

@phisco with @pedjak's SSA work I expect the applicators basically going away.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Crossplane does not currently have enough maintainers to address every issue and pull request. This pull request has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Adding a comment starting with /fresh will mark this PR as not stale.

@github-actions github-actions bot added stale and removed stale labels Sep 3, 2024
@github-actions GitHub Actions
Copy link

Crossplane does not currently have enough maintainers to address every issue and pull request. This pull request has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Adding a comment starting with /fresh will mark this PR as not stale.

@github-actions github-actions bot added the stale label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muvaf muvaf Awaiting requested review from muvaf muvaf is a code owner automatically assigned from crossplane/crossplane-maintainers

@pedjak pedjak Awaiting requested review from pedjak pedjak was automatically assigned from crossplane/crossplane-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sttts @phisco