Simplify error handling

BigGold1310 · negz · BigGold1310 · commit c2c7bbec1204 · 2024-11-14T10:03:33.000Z
Simplify error handling by directly returning the error

Co-authored-by: Nic Cope &lt;nicc@rk0n.org&gt;
Signed-off-by: Cyrill Näf &lt;cyrill.naef@gmail.com&gt;
diff --git a/resource/composed/composed.go b/resource/composed/composed.go
@@ -63,11 +63,7 @@ func To[T runtime.Object](un *Unstructured, obj T) error {
 		return errors.Errorf("GVK %v is not known by the scheme for the provided object type", un.GetObjectKind().GroupVersionKind())
 	}
 
-	err = runtime.DefaultUnstructuredConverter.FromUnstructured(un.Object, obj)
-	if err != nil {
-		return err
-	}
-	return nil
+	return runtime.DefaultUnstructuredConverter.FromUnstructured(un.Object, obj)
 }
 
 // From creates a new unstructured composed resource from the supplied object.

Original file line number	Diff line number	Diff line change
`@@ -63,11 +63,7 @@ func To[T runtime.Object](un *Unstructured, obj T) error {`
`63`	`63`	`return errors.Errorf("GVK %v is not known by the scheme for the provided object type", un.GetObjectKind().GroupVersionKind())`
`64`	`64`	`}`
`65`	`65`
`66`		`- err = runtime.DefaultUnstructuredConverter.FromUnstructured(un.Object, obj)`
`67`		`- if err != nil {`
`68`		`- return err`
`69`		`- }`
`70`		`- return nil`
	`66`	`+ return runtime.DefaultUnstructuredConverter.FromUnstructured(un.Object, obj)`
`71`	`67`	`}`
`72`	`68`
`73`	`69`	`// From creates a new unstructured composed resource from the supplied object.`