Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate logic in ScheduleSortingAttributes #9

Open
JasonFreeberg opened this issue Dec 27, 2020 · 0 comments
Open

Consolidate logic in ScheduleSortingAttributes #9

JasonFreeberg opened this issue Dec 27, 2020 · 0 comments
Labels

Comments

@JasonFreeberg
Copy link
Contributor

There's some redundant logic in the ScheduleSortingAttributes class. This can be moved out into a private method to keep code dry.

This is the redundant logic. This is copied in a few places.

 allTimesAndPlaces.forEach((TimeLocation timeLocation) ->
            timeLocation.getFullDays().forEach((DayOfWeek dayOfWeek) -> {
                // TODO: clean this up using Map.computeIfAbsent(...)
                if (groupedTimes.containsKey(dayOfWeek)) {
                    groupedTimes.get(dayOfWeek).add(timeLocation);
                } else {
                    groupedTimes.put(dayOfWeek, new ArrayList<>());
                    groupedTimes.get(dayOfWeek).add(timeLocation);
                }
            })
        );
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant