Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Go-routine leak when subscribing to jobs #47

Open
csweichel opened this issue Jan 30, 2020 · 1 comment
Open

[bug] Go-routine leak when subscribing to jobs #47

csweichel opened this issue Jan 30, 2020 · 1 comment
Labels
bug Something isn't working server

Comments

@csweichel
Copy link
Owner

Werft seems to leak go-routines and memory over time.
After running werft for about 72h and running about 200 jobs in that time, we have 9883 go routines. Memory consumption has rissen to about 136 megabytes.
@csweichel csweichel added bug Something isn't working server labels Jan 30, 2020
csweichel pushed a commit that referenced this issue Jan 30, 2020
[server] Set MaxConnectionIdle to avoid go-routine leak
17efe49 
Should help with #47
@csweichel csweichel changed the title [bug] Go-routine leak when running jobs [bug] Go-routine leak when subscribing to jobs Jan 31, 2020
@csweichel
Copy link
Owner Author

This issue seems be related to the Subscribe handler not cleaning up properly, i.e. it doesn't react to context cancelation. See this pprof output:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csweichel