Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@packages/draft-modal incompatible with React 17 #1184

Closed
lijuenc opened this issue Mar 4, 2021 · 1 comment
Closed

@packages/draft-modal incompatible with React 17 #1184

lijuenc opened this issue Mar 4, 2021 · 1 comment

Comments

@lijuenc
Copy link

lijuenc commented Mar 4, 2021

When using the Kaizen modal with React 17 you might encounter an error that says Unable to find node on an unmounted component.

Screen Shot 2021-03-04 at 12 51 26 pm

This affects all React modals as the error appears to be originating from the use of a CSSTransition in our GenericModal. CSSTransition is a component from the react-transition-group package and is used to perform animations when opening and closing the modal.

Using something as simple as <GenericModal isOpen={isOpen}>test</GenericModal> and toggling the value of isOpen from true to false or false to true will cause this error.

I have a repository with a minimal reproducible scenario here. It just has the draft modal package, React 17, and a button that attempts to open a modal.

https://github.com/cultureamp/lijuenc-kaizen-modal

@lijuenc
Copy link
Author

lijuenc commented Apr 7, 2021

Fixed by #1301

@lijuenc lijuenc closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants