Beginner: Passing Multiple Entities to functions

[Simon-Says-eng]

Hi,
i am fresh on the boat on pyscript and had my first experiences with my covers. Now there is a basic question i cannot solve.
i try to open and close multiple covers at ones. But i need to tap 2 times on the button to get both start working. I would understand, if they would start each after the other. But after the first, it just stops working.
It is a very basic question but i could not find the answer.

          - type: custom:button-card
            icon: mdi:arrow-expand-up
            tap_action:
              action: call-service
              service: pyscript.group_cover_control
              service_data:
                entities:
                  - cover.eltako_gw1_00_00_00_13
                  - cover.eltako_gw1_00_00_00_14
                movement: "complete_up"
            show_name: false

#!/usr/bin/env python3

import asyncio

def group_cover_control(entities=None, movement=None):
    """
    Move a group of cover entities into the same state while ensuring synchronization.

    Args:
        entities (list): A list of entity IDs to control.
        movement (str): The desired movement for all entities (e.g., 'complete_up', 'complete_down', 'single_up', 'single_down').
    """
    log.info(f"group_cover_control: Moving group of entities {entities} with movement {movement}")

    if not entities or not isinstance(entities, list):
        log.error("No entities provided or invalid format. Expected a list of entity IDs.")
        return

    if movement not in ["complete_up", "complete_down", "single_up", "single_down"]:
        log.error(f"Invalid movement {movement}. Must be one of 'complete_up', 'complete_down', 'single_up', 'single_down'.")
        return

    # Start movement for all entities
    for entity_id in entities:
        try:
            log.info(f"Starting movement for entity {entity_id} with movement {movement}")
            cover_start_movement(entity_id=entity_id, movement=movement)

        except Exception as e:
            log.error(f"Failed to start movement for {entity_id}. Error: {e}")

    # Pause for fixed duration for single movements
    if movement in ["single_up", "single_down"]:
        asyncio.sleep(1)

    # Stop movement for single movements only
    if movement in ["single_up", "single_down"]:
        for entity_id in entities:
            try:
                log.info(f"Stopping movement for entity {entity_id} with movement {movement}")
                cover_stop_movement(entity_id=entity_id)
            except Exception as e:
                log.error(f"Failed to stop movement for {entity_id}. Error: {e}")

def cover_control(entity_id=None, movement=None):
    """
    Control the cover movement using separate start and stop functions, with synchronization.

    Args:
        entity_id (str): The ID of the cover entity.
        movement (str): The desired movement for the entity (e.g., 'complete_up', 'complete_down', 'single_up', 'single_down').
    """
    log.info(f"cover_control: Received entity_id {entity_id}, movement {movement}")

    if not entity_id:
        log.error("No entity_id provided.")
        return

    if movement not in ["complete_up", "complete_down", "single_up", "single_down"]:
        log.error(f"Invalid movement {movement}. Must be one of 'complete_up', 'complete_down', 'single_up', 'single_down'.")
        return

    # Start movement
    cover_start_movement(entity_id=entity_id, movement=movement)

    # Pause for single movements only
    if movement in ["single_up", "single_down"]:
        asyncio.sleep(1)

    # Stop movement for single movements only
    if movement in ["single_up", "single_down"]:
        cover_stop_movement(entity_id=entity_id)

def cover_start_movement(entity_id=None, movement=None):
    """
    Start the cover movement based on the specified action.

    Args:
        entity_id (str): The ID of the cover entity.
        movement (str): The desired movement for the entity (e.g., 'complete_up', 'complete_down', 'single_up', 'single_down').
    """
    log.info(f"Test Test Test")
    log.info(f"cover_start_movement: Starting movement for {entity_id}, movement {movement}")

    if movement == "complete_up":
        cover.open_cover(entity_id=entity_id)  # Trigger full up movement
        log.info(f"Cover {entity_id} started moving completely up.")
    elif movement == "complete_down":
        cover.close_cover(entity_id=entity_id)  # Trigger full down movement
        log.info(f"Cover {entity_id} started moving completely down.")
    elif movement == "single_up":
        cover.open_cover(entity_id=entity_id)  # Trigger a brief up movement
        log.info(f"Cover {entity_id} started moving slightly up.")
    elif movement == "single_down":
        cover.close_cover(entity_id=entity_id)  # Trigger a brief down movement
        log.info(f"Cover {entity_id} started moving slightly down.")

def cover_stop_movement(entity_id=None):
    """
    Stop the cover movement.

    Args:
        entity_id (str): The ID of the cover entity.
    """
    log.info(f"cover_stop_movement: Stopping movement for {entity_id}")
    cover.stop_cover(entity_id=entity_id)  # Stop any ongoing movement
    log.info(f"Cover {entity_id} movement stopped.")

[mefranklin6]

Interesting! Please post your logs after a single button press.