Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Team Data Change Working? #486

Closed
adinwritescode opened this issue Oct 24, 2023 · 1 comment · Fixed by #492
Closed

Fix Team Data Change Working? #486

adinwritescode opened this issue Oct 24, 2023 · 1 comment · Fixed by #492

Comments

@adinwritescode
Copy link

Sport

Football

Summary

Hi,

I've been using this project pretty regularly (~every day) since the season started but got an error just this morning due to the change to team data. I updated to v0.32 which has resolved the error, but I'm seeing a few other things that are making usability difficult, inlcuding

  • There seems to be .owner attribute for teams anymore
  • Team names are showing as "Unknown Unknown" for all previous years

Thanks!

Logs/Data

Screenshot of a schedule from 2022:

image
@cwendt94
Copy link
Owner

Thanks for reporting this! Yeah they removed owner names data so I removed it but I think we should still include the owner id. Someone created a PR adding owner id back here, so hopefully that will be in soon.

For the Team name, I recently started seeing that as well when some integration tests started failing. I need to look into it but I think they might have updated their previous data to the new team format that they added this year that was fixed in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants