Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back functionality to pull owner names #497

Open
johnny-papercut opened this issue Oct 27, 2023 · 4 comments
Open

Add back functionality to pull owner names #497

johnny-papercut opened this issue Oct 27, 2023 · 4 comments

Comments

@johnny-papercut
Copy link

Sport

Football

Summary

After updating to 0.33.0, it seems like owners are now represented by their ID and not their human-readable names.

Can owner names be surfaced again?

@Kjeldgaard
Copy link
Contributor

You can find inspiration here #487 (comment), on how to get owner names.

@cwendt94
Copy link
Owner

cwendt94 commented Nov 1, 2023

Yeah, I will look to adding it back in the new couple days. ESPN had to mess up their data for a little and removed it, but of course now they added it back.

@joeyagreco
Copy link
Contributor

joeyagreco commented Dec 5, 2023

Commenting for visibility. Updating to version 0.33.0 broke functionality in a library of mine sadly :/

AttributeError: 'Team' object has no attribute 'owner'. Did you mean: 'owners'?

@cwendt94
Copy link
Owner

cwendt94 commented Dec 5, 2023

Owners is back in v0.34.0, format is a little different as they removed owner names in public leagues.

Team.owners will now be an array of dict. It will look like

[{ id: '1234', displayName: 'team', firstName: 'Bob', lastName: 'Joe'}]

However in public leagues, the name attributes will not be populated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants