Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide labels in fcc #31

Open
1ycx opened this issue May 2, 2020 · 5 comments
Open

Provide labels in fcc #31

1ycx opened this issue May 2, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@1ycx
Copy link

1ycx commented May 2, 2020

I think it would be better if we can provide custom labels as input in the fcc, which if not provided defaults to the usual 1, 2, 3, 4, etc

@cwerner
Copy link
Owner

cwerner commented May 2, 2020

Sure, my initial thoughts were to keep this simple and have labels be equivalent to the number key input. Since the GUI now also features buttons for mouse input it’s more feasible to add this...

I use fcc actually for multiple purposes:

  • rate the quality/ suitability of an image that is already in the right class (I.e. 1 high quality, 2 ok, 3 kinda bad etc)
  • indicate different scopes (I.e. 1 full guitar, 2 only the headstock and neck, 3 only some details of the model)

The idea is to have a way to create different subsets of the data by filtering on this later if needed (I,e, include only the best images, etc.).

One could also use it for plain classification (as I think you have in mind), however for me this is already achieved by giving multiple lines (each line for one class) to fcd

I’m not sure I can work on this the next week(s), however I’m happy to accept a PR that lets the user edit the button content to represent classes 😉

@cwerner cwerner added the enhancement New feature or request label May 2, 2020
@1ycx
Copy link
Author

1ycx commented May 2, 2020

I wanted to see If I can contribute in any way. Like a quick change of few lines but then I see there's classes and class methods which I have little experience with ( I use functions normally ) and I was like "continue this maybe sometime later".
Also I have little experience with tkinter 😅

@1ycx
Copy link
Author

1ycx commented May 2, 2020

I was doing the fastai-v3 course on deep learning and there arose the need to to create a dataset

@cwerner
Copy link
Owner

cwerner commented May 2, 2020

No worries. I like the idea... I might give it the shot this weekend actually. Not sure how hard it is to implement this with tk 🤔
I’m no expert either and it still feels pretty archaic to me...

However, as said you might be able to achieve this with fcd alone (if your search queries are for each individual class) and only use fcc to remove bad/ wrong images after the download...

@cwerner
Copy link
Owner

cwerner commented May 2, 2020

One could simply read a small config file for naming the buttons, but I’d aim to have this as an interactive operation within the GUI itself...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants