Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OCI helm registry auth #524

Open
petar-cvit opened this issue Aug 23, 2024 · 6 comments · May be fixed by pravintargaryen/cyclops#1
Open

Support OCI helm registry auth #524

petar-cvit opened this issue Aug 23, 2024 · 6 comments · May be fixed by pravintargaryen/cyclops#1
Labels
controller Update on controller go Pull requests that update Go code hacktoberfest help wanted Extra attention is needed kubernetes k8s related issues ⚔️ Quest Tracks quest-bot quests

Comments

@petar-cvit
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
When fetching private templates, Cyclops injects auth data (username and password) into the request. This is supported only when fetching templates from GitHub, but not when fetching from an OCI registry.

Here is the example of how credentials are fetched from the cluster when fetching a template from GitHub and here is the function fetching data from an OCI based registry.

@petar-cvit petar-cvit added help wanted Extra attention is needed go Pull requests that update Go code controller Update on controller kubernetes k8s related issues labels Aug 23, 2024
@pravintargaryen
Copy link

Hi @petar-cvit please review #525 as the commit for this also ended up in the same PR. Please reject (8c062f5) and I will send a separate PR

@petar-cvit
Copy link
Collaborator Author

Hey @pravintargaryen, can you close the existing PRs and create new ones with changes only for a single issue?

@pravintargaryen pravintargaryen linked a pull request Aug 25, 2024 that will close this issue
2 tasks
@pravintargaryen
Copy link

@petar-cvit please check

Copy link

quest-bot bot commented Oct 4, 2024

New Quest! image New Quest!

A new Quest has been launched in @cyclops-ui’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #524 to link your PR to this Quest.

Questions? Check out the docs.

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 4, 2024
@pravintargaryen
Copy link

@quest-bot embark

Copy link

quest-bot bot commented Oct 4, 2024

@pravintargaryen has embarked on their Quest. 🗡

  • @pravintargaryen has been on GitHub since 2022.
  • They have merged 17 public PRs in that time.
  • Their swords are blessed with JavaScript and HTML magic ✨
  • They have contributed to this repo before.

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller Update on controller go Pull requests that update Go code hacktoberfest help wanted Extra attention is needed kubernetes k8s related issues ⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants