Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Modules by TargetNamespace #640

Open
KaradzaJuraj opened this issue Oct 21, 2024 · 10 comments · May be fixed by #666
Open

Filter Modules by TargetNamespace #640

KaradzaJuraj opened this issue Oct 21, 2024 · 10 comments · May be fixed by #666
Assignees
@DDibyajyot
Labels
controller Update on controller go Pull requests that update Go code good first issue Good for newcomers hacktoberfest ⚔️ Quest Tracks quest-bot quests react typescript UI Update on the UI

Comments

@KaradzaJuraj
Copy link
Collaborator

When deploying a module, you can deploy it to a targeted namespace. On the modules screen, you can filter by status, but we want to add the option to filter by targetNamespace as well.

Add the targetNamespace property to ModuleListToDTO function in mapper/modules. This will enable you to gather all the modules with the modules/list call and access their targetNamespace.

With the /namespaces call, you can get a list of all the available namespaces in the cluster. Use that list to create a filter for filtering modules based on their targetNamespace.
@KaradzaJuraj KaradzaJuraj added good first issue Good for newcomers go Pull requests that update Go code controller Update on controller UI Update on the UI typescript react hacktoberfest labels Oct 21, 2024
@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 21, 2024
@quest-bot quest-bot
Copy link

quest-bot bot commented Oct 21, 2024

New Quest! image New Quest!

A new Quest has been launched in @cyclops-ui’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.

Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #640 to link your PR to this Quest.

Questions? Check out the docs.

@DDibyajyot
Copy link

Hey could I work on this?

@KaradzaJuraj
Copy link
Collaborator Author

Hey @DDibyajyot, I'm assigning the issue to you. Thanks for picking this up!

@jrbe228 jrbe228 mentioned this issue Oct 27, 2024
Open
@s-vamshi
Copy link
Contributor

Hey @KaradzaJuraj @petar-cvit ,
Can i work on this issue if @DDibyajyot hasn't started working on this?

@DDibyajyot
Copy link

Hey, currently working on this but please have a go at it as well @s-vamshi!

@s-vamshi
Copy link
Contributor

Can I also start working on this issue @KaradzaJuraj @petar-cvit as mentioned by @DDibyajyot ?

Please let me know if that's okay with you guys!

@s-vamshi
Copy link
Contributor

s-vamshi commented Oct 31, 2024 •
edited
Loading

hey @KaradzaJuraj @petar-cvit made the changes as shown below

screen-capture.1.webm

image

@s-vamshi
Copy link
Contributor

@quest-bot embark

@quest-bot quest-bot
Copy link

quest-bot bot commented Oct 31, 2024

@s-vamshi has embarked on their Quest. 🗡

  • @s-vamshi has been on GitHub since 2020.
  • They have merged 40 public PRs in that time.
  • Their swords are blessed with Shell and Dockerfile magic ✨
  • They have contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

This was referenced Oct 31, 2024
Closed
Open
@quest-bot quest-bot
Copy link

quest-bot bot commented Oct 31, 2024

🧚 @s-vamshi has submitted PR #666 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DDibyajyot DDibyajyot

Labels
controller Update on controller go Pull requests that update Go code good first issue Good for newcomers hacktoberfest ⚔️ Quest Tracks quest-bot quests react typescript UI Update on the UI
Projects
None yet
Milestone
No milestone
3 participants
@s-vamshi @DDibyajyot @KaradzaJuraj