Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight on mobile click #59

Open
Garett-MacGowan opened this issue Oct 2, 2022 · 4 comments
Open

Highlight on mobile click #59

Garett-MacGowan opened this issue Oct 2, 2022 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@Garett-MacGowan
Copy link

Garett-MacGowan commented Oct 2, 2022

Version 2.5.0

Steps to Reproduce

When users interact with the menu on mobile devices, the burger is highlighted during the transition.

Reproduceable on the example site: https://hamburger-react.netlify.app/

Note

This may or may not be expected, but it would be nice to have the option to turn it off. I recognize most click events on mobile are associated with this behavior.

Workaround

My temporary (tested only on chrome) workaround using style jsx:

<div className='burger-container' onClick={props.onClick}>
    <Spiral size={28} label='menu' easing="ease-out" hideOutline={true}/>
</div>
<style jsx>{`
  .burger-container:first-child {
    -webkit-tap-highlight-color: transparent;
    -webkit-touch-callout: none;
    -webkit-user-select: none;
    -moz-user-select: none;
    -ms-user-select: none;
    user-select: none;
  }
`}</style>

webkit, moz, ms, and user-select statements taken from this stack overflow.

@luukdv
Copy link
Collaborator

luukdv commented Oct 2, 2022

Thanks for reporting.

I indeed decided not to turn this off by default since it's expected on click, but I agree it would be helpful to make it more easy to turn off.

In version 3.0 you will be able to simply forward style and className, for now this would be simplest:

.hamburger-react { -webkit-touch-callout: … }

@fffan64
Copy link

fffan64 commented Jan 29, 2023

hello, thanks for the pkg it's great

any eta for the v3 release ?
thanks !

@luukdv
Copy link
Collaborator

luukdv commented Jan 29, 2023

No ETA yet! Working on it in the v3 branch whenever I can, but I've been short on time. I'll let you know when it's ready to test.

@luukdv
Copy link
Collaborator

luukdv commented Jun 27, 2023

Update about v3.0: Looking for new owner

@cyntler cyntler added this to the v3.0.0 milestone Aug 16, 2023
@cyntler cyntler added the enhancement New feature or request label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants