Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #74

Open
majkoll opened this issue May 31, 2024 · 0 comments
Open

Accessibility #74

majkoll opened this issue May 31, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@majkoll
Copy link

majkoll commented May 31, 2024

The toggle button provided is currently rendered as a div element instead of a button element. This approach has accessibility implications as it lacks the necessary ARIA attributes and role needed for proper accessibility support.

For accessibility, it would be better if the toggle button is rendered as a button element. If it must be a div, appropriate ARIA attributes and roles should be added to ensure it is accessible (e.g. role, aria-pressed).

@cyntler cyntler self-assigned this Jun 2, 2024
@cyntler cyntler added enhancement New feature or request good first issue Good for newcomers labels Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants